Size Change: -16 B (0%)

Total Size: 1.24 MB

_{compressed-size-action}

The rule (margin: 0 0 1em 0) seems to be applied, testing an emtpy theme.
Video shows inspector. Used an empty theme.

@bph I think that's expected, what did you expect?

Yes. I didn't find anything not working. Confirming all as expected. 👏👏🚀👍

Yes. I didn't find anything not working. Confirming all as expected. 👏👏🚀👍
Just wanted to document what it looks like, in case someone needs a visual 🙂 At first I used a opinionated theme and didn't find the changes in the Inspector, until I used an 'empty' theme.

Thank you, that's very helpful :)

The change here seems good. Howeover I'm encountering some awkward default margins as a result in TT2:

Essentially the margin: 0 0 1em 0; rule wins over the logical margin rules introduced in #38816:

In other words, the default bottom margin here conflicts with the owl selector (* + *) top margins, causing there to be zero margin between image and text.

Is that expected, or are there ways we can tweak this? Should the specificity be reduced one place or another, or increased for the owl selector? If I remove the new theme.json rules, things look good in TT2:

But of course we risk resurfacing #29517.

Should the specificity be reduced one place or another, or increased for the owl selector?

I think ideally the default margins provided by the blocks should have a lower specificity, rather than us increasing the specificity of the layout support. There's a semi-related issue for when folks do want margins to override layout styles (#43404) for which a solution might be to lower the specificity of the layout styles, but it's a challenging thing to do when wrestling with the block's default values, too.

I'm not too sure how we get there, but from my perspective I think we'd want something like:

• Lowest specificity: default margins for blocks (what's in this PR)
• Next up: layout owl selector styles
• Higher priority: margins set in theme.json by the theme
• Next priority, margins set at the individual block level in post content

I created a PR to try to fix this bug here: #43792

I added the label needs dev note prophylactically, as I am unsure if this change will catch classic theme developers by surprise otherwise.

@bph we did publish a post about it already: https://make.wordpress.org/core/2022/08/01/moving-core-block-styling-to-json/

Is that sufficient?

I think this is covered by the dev note here: #34180 (comment)